1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

n-api: update reference test

Browse Source 
Remove the necessity for allocating on the heap, and assert that the
correct pointer gets passed to the finalizer.

PR-URL: https://github.com/nodejs/node/pull/19086
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Gabriel Schulhof 2018-03-02 09:41:12 -05:00
parent 68d508a9e0
commit d83f8303fd
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/addons-napi/test_reference/test_reference.c
View File

@ -1,6 +1,5 @@
#include <node_api.h> #include <node_api.h>
#include "../common.h" #include "../common.h"
#include <stdlib.h>
static int test_value = 1; static int test_value = 1;
static int finalize_count = 0; static int finalize_count = 0;
@ -13,7 +12,9 @@ napi_value GetFinalizeCount(napi_env env, napi_callback_info info) {
} }
void FinalizeExternal(napi_env env, void* data, void* hint) { void FinalizeExternal(napi_env env, void* data, void* hint) {
free(data); int *actual_value = data;
NAPI_ASSERT_RETURN_VOID(env, actual_value == &test_value,
"The correct pointer was passed to the finalizer");
finalize_count++; finalize_count++;
} }
@ -33,13 +34,10 @@ napi_value CreateExternal(napi_env env, napi_callback_info info) {
} }
napi_value CreateExternalWithFinalize(napi_env env, napi_callback_info info) { napi_value CreateExternalWithFinalize(napi_env env, napi_callback_info info) {
int* data = malloc(sizeof(int));
*data = test_value;
napi_value result; napi_value result;
NAPI_CALL(env, NAPI_CALL(env,
napi_create_external(env, napi_create_external(env,
data, &test_value,
FinalizeExternal, FinalizeExternal,
NULL, /* finalize_hint */ NULL, /* finalize_hint */
&result)); &result));