1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

timers: use start instead of stop + start

Browse Source 
Instead of calling stop + start from the refresh method
of Timeout, instead just call start as libuv already
calls stop if necessary.

PR-URL: https://github.com/nodejs/node/pull/18486
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This commit is contained in:
Anatoli Papirovski 2018-01-31 11:08:25 -05:00
parent 71c0d0370a
commit d7894f3969
No known key found for this signature in database
GPG Key ID: 614E2E1ABEB4B2C0
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/internal/timers.js
View File

@ -85,7 +85,6 @@ Timeout.prototype[refreshFnSymbol] = function refresh() {
// Would be more ideal with uv_timer_again(), however that API does not // Would be more ideal with uv_timer_again(), however that API does not
// cause libuv's sorted timers data structure (a binary heap at the time // cause libuv's sorted timers data structure (a binary heap at the time
// of writing) to re-sort itself. This causes ordering inconsistencies. // of writing) to re-sort itself. This causes ordering inconsistencies.
this._handle.stop();
this._handle.start(this._idleTimeout); this._handle.start(this._idleTimeout);
} else if (this[unrefedSymbol]) { } else if (this[unrefedSymbol]) {
getTimers()._unrefActive(this); getTimers()._unrefActive(this);