1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-async-wrap-*

Browse Source 
* `assert.equal()` -> `assert.strictEqual()`
* add duration to `setTimeout()`

PR-URL: https://github.com/nodejs/node/pull/9663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
This commit is contained in:
Rich Trott 2016-11-17 10:25:57 -08:00
parent 440057eae0
commit d6dc2e8d44
4 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-async-wrap-check-providers.js
View File

@ -46,7 +46,7 @@ async_wrap.setupHooks({ init });
async_wrap.enable(); async_wrap.enable();
setTimeout(function() { }); setTimeout(function() { }, 1);
fs.stat(__filename, noop); fs.stat(__filename, noop);

10
test/parallel/test-async-wrap-disabled-propagate-parent.js
View File

@ -18,12 +18,12 @@ function init(uid, type, parentUid, parentHandle) {
cntr++; cntr++;
// Cannot assert in init callback or will abort. // Cannot assert in init callback or will abort.
process.nextTick(() => { process.nextTick(() => {
assert.equal(providers[type], 'TCPWRAP'); assert.strictEqual(providers[type], 'TCPWRAP');
assert.equal(parentUid, server._handle[uidSymbol], assert.strictEqual(parentUid, server._handle[uidSymbol],
'server uid doesn\'t match parent uid'); 'server uid doesn\'t match parent uid');
assert.equal(parentHandle, server._handle, assert.strictEqual(parentHandle, server._handle,
'server handle doesn\'t match parent handle'); 'server handle doesn\'t match parent handle');
assert.equal(this, client._handle, 'client doesn\'t match context'); assert.strictEqual(this, client._handle, 'client doesn\'t match context');
}); });
} }
} }
@ -48,5 +48,5 @@ async_wrap.disable();
process.on('exit', function() { process.on('exit', function() {
// init should have only been called once with a parent. // init should have only been called once with a parent.
assert.equal(cntr, 1); assert.strictEqual(cntr, 1);
}); });

10
test/parallel/test-async-wrap-propagate-parent.js
View File

@ -18,12 +18,12 @@ function init(uid, type, parentUid, parentHandle) {
cntr++; cntr++;
// Cannot assert in init callback or will abort. // Cannot assert in init callback or will abort.
process.nextTick(() => { process.nextTick(() => {
assert.equal(providers[type], 'TCPWRAP'); assert.strictEqual(providers[type], 'TCPWRAP');
assert.equal(parentUid, server._handle[uidSymbol], assert.strictEqual(parentUid, server._handle[uidSymbol],
'server uid doesn\'t match parent uid'); 'server uid doesn\'t match parent uid');
assert.equal(parentHandle, server._handle, assert.strictEqual(parentHandle, server._handle,
'server handle doesn\'t match parent handle'); 'server handle doesn\'t match parent handle');
assert.equal(this, client._handle, 'client doesn\'t match context'); assert.strictEqual(this, client._handle, 'client doesn\'t match context');
}); });
} }
} }
@ -47,5 +47,5 @@ const server = net.createServer(function(c) {
process.on('exit', function() { process.on('exit', function() {
// init should have only been called once with a parent. // init should have only been called once with a parent.
assert.equal(cntr, 1); assert.strictEqual(cntr, 1);
}); });

6
test/parallel/test-async-wrap-throw-from-callback.js
View File

@ -49,8 +49,8 @@ if (typeof process.argv[2] === 'string') {
} else { } else {
process.on('exit', (code) => { process.on('exit', (code) => {
assert.equal(msgCalled, callbacks.length); assert.strictEqual(msgCalled, callbacks.length);
assert.equal(msgCalled, msgReceived); assert.strictEqual(msgCalled, msgReceived);
}); });
callbacks.forEach((item) => { callbacks.forEach((item) => {
@ -67,7 +67,7 @@ if (typeof process.argv[2] === 'string') {
if (errstring.includes('Error: ' + item)) if (errstring.includes('Error: ' + item))
msgReceived++; msgReceived++;
assert.equal(code, 1, `${item} closed with code ${code}`); assert.strictEqual(code, 1, `${item} closed with code ${code}`);
}); });
}); });
} }