1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

url: do not use HandleScope in ToObject

Browse Source 
It is not needed / invalidates the returned value unlike EscapableHandleScope

PR-URL: https://github.com/nodejs/node/pull/14096
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Bradley Farias 2017-07-05 17:22:43 -05:00 committed by Refael Ackermann
parent 24f79a775a
commit d49e6693fe
No known key found for this signature in database
GPG Key ID: CD704BD80FDDDB64
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/node_url.cc
View File

@ -2085,7 +2085,6 @@ static void DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
const Local<Value> URL::ToObject(Environment* env) const {
Isolate* isolate = env->isolate();
Local<Context> context = env->context();
HandleScope handle_scope(isolate);
Context::Scope context_scope(context);
const Local<Value> undef = Undefined(isolate);