test: make use of globals explicit

Use `global` to be explicit that a global variable is intended.

PR-URL: https://github.com/nodejs/node/pull/6014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2016-04-01 22:20:55 -07:00
parent ae2be27add
commit d416a59f91

View File

@ -14,25 +14,25 @@ assert.throws(function() {
vm.runInThisContext('throw new Error(\'test\');'); vm.runInThisContext('throw new Error(\'test\');');
}, /test/); }, /test/);
hello = 5; global.hello = 5;
vm.runInThisContext('hello = 2'); vm.runInThisContext('hello = 2');
assert.equal(2, hello); assert.equal(2, global.hello);
console.error('pass values'); console.error('pass values');
code = 'foo = 1;' + var code = 'foo = 1;' +
'bar = 2;' + 'bar = 2;' +
'if (typeof baz !== \'undefined\') throw new Error(\'test fail\');'; 'if (typeof baz !== \'undefined\') throw new Error(\'test fail\');';
foo = 2; global.foo = 2;
obj = { foo: 0, baz: 3 }; global.obj = { foo: 0, baz: 3 };
/* eslint-disable no-unused-vars */ /* eslint-disable no-unused-vars */
var baz = vm.runInThisContext(code); var baz = vm.runInThisContext(code);
/* eslint-enable no-unused-vars */ /* eslint-enable no-unused-vars */
assert.equal(0, obj.foo); assert.equal(0, global.obj.foo);
assert.equal(2, bar); assert.equal(2, global.bar);
assert.equal(1, foo); assert.equal(1, global.foo);
console.error('call a function'); console.error('call a function');
f = function() { foo = 100; }; global.f = function() { global.foo = 100; };
vm.runInThisContext('f()'); vm.runInThisContext('f()');
assert.equal(100, foo); assert.equal(100, global.foo);