1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

module: use compileFunction over Module.wrap

Browse Source 
Use vm.compileFunction (which is a binding for
v8::CompileFunctionInContext) instead of Module.wrap internally in
Module._compile for the cjs loader.

Fixes: https://github.com/nodejs/node/issues/17396

PR-URL: https://github.com/nodejs/node/pull/21573
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Ujjwal Sharma 2018-06-28 12:15:15 +05:30
parent 8375c706ad
commit d345b0dc12
No known key found for this signature in database
GPG Key ID: 1FD3B47B83F46621
1 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lib/internal/modules/cjs/loader.js
View File

@ -700,19 +700,13 @@ Module.prototype._compile = function(content, filename) {
content = stripShebang(content); content = stripShebang(content);
// create wrapper function const compiledWrapper = vm.compileFunction(content, [
var wrapper = Module.wrap(content); 'exports',
'require',
var compiledWrapper = vm.runInThisContext(wrapper, { 'module',
filename: filename, '__filename',
lineOffset: 0, '__dirname',
displayErrors: true, ], { filename });
importModuleDynamically: experimentalModules ? async (specifier) => {
if (asyncESM === undefined) lazyLoadESM();
const loader = await asyncESM.loaderPromise;
return loader.import(specifier, normalizeReferrerURL(filename));
} : undefined,
});
var inspectorWrapper = null; var inspectorWrapper = null;
if (process._breakFirstLine && process._eval == null) { if (process._breakFirstLine && process._eval == null) {