1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tls: handle error events with _tlsError

Browse Source 
Previously `TLSSocket#_emitTLSError` was used as an `error` event
handler. However that function can emit `error` event itself, so it is
not suitable for such use. Luckily the event can be emitted only when
the control is released, so this looping-error can't happen.

Replace the error handler for clarity and correctness.

PR-URL: https://github.com/nodejs/node/pull/8889
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Fedor Indutny 2016-10-01 21:17:51 +02:00
parent 2cfd7fd8f9
commit d33c4bf97b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/_tls_wrap.js
View File

@ -272,7 +272,7 @@ function TLSSocket(socket, options) {
// Proxy for API compatibility
this.ssl = this._handle;
this.on('error', this._emitTLSError);
this.on('error', this._tlsError);
this._init(socket, wrap);
@ -554,7 +554,7 @@ TLSSocket.prototype._releaseControl = function() {
if (this._controlReleased)
return false;
this._controlReleased = true;
this.removeListener('error', this._emitTLSError);
this.removeListener('error', this._tlsError);
return true;
};