1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: use assert() in N-API async test

Browse Source 
The `Execute()` callback is not allowed to call into JS, so
we should use `assert()` instead of potentially throwing JS errors.

PR-URL: https://github.com/nodejs/node/pull/28423
Fixes: https://github.com/nodejs/help/issues/1998
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Anna Henningsen 2019-06-25 16:25:48 +02:00 committed by Daniel Bevenius
parent 6045fbbb5e
commit d11b5382d6
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/node-api/test_async/test_async.cc
View File

@ -1,3 +1,4 @@
#include <assert.h>
#include <stdio.h> #include <stdio.h>
#include <node_api.h> #include <node_api.h>
#include "../../js-native-api/common.h" #include "../../js-native-api/common.h"
@ -29,10 +30,7 @@ void Execute(napi_env env, void* data) {
#endif #endif
carrier* c = static_cast<carrier*>(data); carrier* c = static_cast<carrier*>(data);
if (c != &the_carrier) { assert(c == &the_carrier);
napi_throw_type_error(env, nullptr, "Wrong data parameter to Execute.");
return;
}
c->_output = c->_input * 2; c->_output = c->_input * 2;
} }