From cf6acf2a1a8717eb55aec8df79121ee6a75611f4 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 27 Jun 2013 03:18:41 +0200 Subject: [PATCH] buffer: add comment explaining buffer alignment Avoids alignment issues (unaligned loads/stores) on ARM. Originally added in commit 285d8c6. Fixes #3030. --- lib/buffer.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/buffer.js b/lib/buffer.js index 000c54b3a88..51406b6ed61 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -199,8 +199,8 @@ function Buffer(subject, encoding, offset) { if (!pool || pool.length - pool.used < this.length) allocPool(); this.parent = pool; this.offset = pool.used; - pool.used += this.length; - if (pool.used & 7) pool.used = (pool.used + 8) & ~7; + // Align on 8 byte boundary to avoid alignment issues on ARM. + pool.used = (pool.used + this.length + 7) & ~7; } else { // Zero-length buffer