1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

stream: delete redundant code

Browse Source 
In `Writable.prototype.end()`, `state.ending` is true after calling
`endWritable()` and it doesn't reset to false.

In `Writable.prototype.uncork()`, `state.finished` must be false
if `state.bufferedRequest` is true.

PR-URL: https://github.com/nodejs/node/pull/18145
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
陈刚 2018-01-14 23:34:18 +08:00 committed by Matteo Collina
parent caa26cbf13
commit ce83099d3e
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/_stream_writable.js
View File

@ -297,7 +297,6 @@ Writable.prototype.uncork = function() {
if (!state.writing && if (!state.writing &&
!state.corked && !state.corked &&
!state.finished &&
!state.bufferProcessing && !state.bufferProcessing &&
state.bufferedRequest) state.bufferedRequest)
clearBuffer(this, state); clearBuffer(this, state);
@ -569,7 +568,7 @@ Writable.prototype.end = function(chunk, encoding, cb) {
} }
// ignore unnecessary end() calls. // ignore unnecessary end() calls.
if (!state.ending && !state.finished) if (!state.ending)
endWritable(this, state, cb); endWritable(this, state, cb);
}; };