1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: remove usc-2 encoding

Browse Source 
Fixes: https://github.com/nodejs/node/issues/21963
PR-URL: https://github.com/nodejs/node/pull/21964
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Brian White 2018-07-25 00:53:55 -04:00 committed by Anna Henningsen
parent 10c850bdee
commit ce5157b22f
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
3 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
benchmark/util/normalize-encoding.js
View File

@ -5,11 +5,11 @@ const assert = require('assert');
const groupedInputs = { const groupedInputs = {
group_common: ['undefined', 'utf8', 'utf-8', 'base64', group_common: ['undefined', 'utf8', 'utf-8', 'base64',
'binary', 'latin1', 'ucs-2', 'usc-2'], 'binary', 'latin1', 'ucs-2'],
group_upper: ['UTF-8', 'UTF8', 'UCS2', 'UTF-16LE', group_upper: ['UTF-8', 'UTF8', 'UCS2', 'UTF-16LE',
'UTF16LE', 'BASE64', 'UCS-2', 'USC-2'], 'UTF16LE', 'BASE64', 'UCS-2'],
group_uncommon: ['foo', '1', 'false', 'undefined', '[]', '{}'], group_uncommon: ['foo', '1', 'false', 'undefined', '[]', '{}'],
group_misc: ['', 'utf16le', 'usc2', 'hex', 'HEX', 'BINARY'] group_misc: ['', 'utf16le', 'hex', 'HEX', 'BINARY']
}; };
const inputs = [ const inputs = [
@ -17,9 +17,7 @@ const inputs = [
'utf8', 'utf-8', 'UTF-8', 'utf8', 'utf-8', 'UTF-8',
'UTF8', 'Utf8', 'uTf-8', 'utF-8', 'UTF8', 'Utf8', 'uTf-8', 'utF-8',
'ucs2', 'UCS2', 'UcS2', 'ucs2', 'UCS2', 'UcS2',
'USC2', 'usc2', 'uSc2',
'ucs-2', 'UCS-2', 'UcS-2', 'ucs-2', 'UCS-2', 'UcS-2',
'usc-2', 'USC-2', 'uSc-2',
'utf16le', 'utf-16le', 'UTF-16LE', 'UTF16LE', 'utf16le', 'utf-16le', 'UTF-16LE', 'UTF16LE',
'binary', 'BINARY', 'latin1', 'base64', 'BASE64', 'binary', 'BINARY', 'latin1', 'base64', 'BASE64',
'hex', 'HEX', 'foo', '1', 'false', 'undefined', '[]', '{}']; 'hex', 'HEX', 'foo', '1', 'false', 'undefined', '[]', '{}'];

1
lib/internal/util.js
View File

@ -127,7 +127,6 @@ function slowCases(enc) {
enc = `${enc}`.toLowerCase(); enc = `${enc}`.toLowerCase();
if (enc === 'utf-8') return 'utf8'; if (enc === 'utf-8') return 'utf8';
if (enc === 'ascii') return 'ascii'; if (enc === 'ascii') return 'ascii';
if (enc === 'usc-2') return 'utf16le';
if (enc === 'ucs-2') return 'utf16le'; if (enc === 'ucs-2') return 'utf16le';
break; break;
case 6: case 6:

3
test/parallel/test-internal-util-normalizeencoding.js
View File

@ -25,9 +25,6 @@ const tests = [
['utf-16le', 'utf16le'], ['utf-16le', 'utf16le'],
['UTF-16LE', 'utf16le'], ['UTF-16LE', 'utf16le'],
['UTF16LE', 'utf16le'], ['UTF16LE', 'utf16le'],
['usc-2', 'utf16le'],
['USC-2', 'utf16le'],
['uSc-2', 'utf16le'],
['binary', 'latin1'], ['binary', 'latin1'],
['BINARY', 'latin1'], ['BINARY', 'latin1'],
['latin1', 'latin1'], ['latin1', 'latin1'],