1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http2: skip writeHead if stream is closed

Browse Source 
Fixes: https://github.com/nodejs/node/issues/57416
PR-URL: https://github.com/nodejs/node/pull/57686
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
This commit is contained in:
Shima Ryuhei 2025-04-05 00:07:09 +09:00 committed by Marco Ippolito
parent d582954434
commit cdf3fa241c
No known key found for this signature in database
GPG Key ID: 27F5E38D5B0A215F
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/internal/http2/compat.js
View File

@ -706,7 +706,7 @@ class Http2ServerResponse extends Stream {
writeHead(statusCode, statusMessage, headers) {
const state = this[kState];
if (state.closed || this.stream.destroyed)
if (state.closed || this.stream.destroyed || this.stream.closed)
return this;
if (this[kStream].headersSent)
throw new ERR_HTTP2_HEADERS_SENT();

23
test/parallel/test-http2-compat-write-head-after-close.js Normal file
View File

@ -0,0 +1,23 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto) { common.skip('missing crypto'); }
const h2 = require('http2');
const server = h2.createServer((req, res) => {
const stream = req.stream;
stream.close();
res.writeHead(200, { 'content-type': 'text/plain' });
});
server.listen(0, common.mustCall(() => {
const port = server.address().port;
const client = h2.connect(`http://localhost:${port}`);
const req = client.request({ ':path': '/' });
req.on('response', common.mustNotCall('head after close should not be sent'));
req.on('end', common.mustCall(() => {
client.close();
server.close();
}));
req.end();
}));