1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

url: use hasIntl instead of try-catch

Browse Source 
Like the other internal modules, we should use
`process.binding('config').hasIntl` instead of `try-catch`
to make sure `icu` is bonded or not.

PR-URL: https://github.com/nodejs/node/pull/11571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
This commit is contained in:
Daijiro Wachi 2017-02-28 10:06:25 +01:00 committed by James M Snell
parent 3b05153cdc
commit cccc6d8545
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/url.js
View File

@ -1,15 +1,7 @@
'use strict'; 'use strict';
function importPunycode() { const { toASCII } = process.binding('config').hasIntl ?
try { process.binding('icu') : require('punycode');
return process.binding('icu');
} catch (e) {
return require('punycode');
}
}
const { toASCII } = importPunycode();
const { StorageObject, hexTable } = require('internal/querystring'); const { StorageObject, hexTable } = require('internal/querystring');
const internalUrl = require('internal/url'); const internalUrl = require('internal/url');
exports.parse = urlParse; exports.parse = urlParse;