1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: use callback to properly propagate error

Browse Source 
The socket will be destroyed upstream through the proper error
flow.

PR-URL: https://github.com/nodejs/node/pull/29178
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Robert Nagy 2019-08-17 13:08:09 +02:00 committed by Rich Trott
parent 490ec9b9c9
commit cc7cec25c5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/net.js
View File

@ -685,7 +685,7 @@ Socket.prototype._writeGeneric = function(writev, data, encoding, cb) {
this._pendingEncoding = ''; this._pendingEncoding = '';
if (!this._handle) { if (!this._handle) {
this.destroy(new ERR_SOCKET_CLOSED(), cb); cb(new ERR_SOCKET_CLOSED());
return false; return false;
} }