fs: fix fs.readFileSync fd leak when get RangeError

2014-08-06 11:21:59 +08:00 · 2014-08-06 11:21:59 +08:00 · cc08106d62
commit cc08106d62
parent 70cc9968f6
1 changed files with 7 additions and 1 deletions
--- a/lib/fs.js
+++ b/lib/fs.js
@ -304,7 +304,13 @@ fs.readFileSync = function(path, options) {
  if (size === 0) {
    buffers = [];
  } else {
-    buffer = new Buffer(size);
+    var threw = true;
+    try {
+      buffer = new Buffer(size);
+      threw = false;
+    } finally {
+      if (threw) fs.closeSync(fd);
+    }
  }

  var done = false;