1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

util: add es6 Symbol support for util.inspect

Browse Source 
* `util.inspect` cannot accept es6 symbol primitive
* It will throw exception if do `util.inspect(Symbol())`
* This also affects repl, console.log, etc.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
This commit is contained in:
gyson 2014-10-01 10:44:39 +08:00 committed by Chris Dickinson
parent 83d7d9e6d8
commit cb97bcd6f9
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/util.js
View File

@ -174,6 +174,7 @@ inspect.styles = {
'undefined': 'grey', 'undefined': 'grey',
'null': 'bold', 'null': 'bold',
'string': 'green', 'string': 'green',
'symbol': 'green',
'date': 'magenta', 'date': 'magenta',
// "name": intentionally not styling // "name": intentionally not styling
'regexp': 'red' 'regexp': 'red'
@ -388,6 +389,9 @@ function formatPrimitive(ctx, value) {
// For some reason typeof null is "object", so special case here. // For some reason typeof null is "object", so special case here.
if (isNull(value)) if (isNull(value))
return ctx.stylize('null', 'null'); return ctx.stylize('null', 'null');
// es6 symbol primitive
if (isSymbol(value))
return ctx.stylize(value.toString(), 'symbol');
} }

9
test/simple/test-util-inspect.js
View File

@ -235,3 +235,12 @@ assert.equal(util.inspect(bool), '{ [Boolean: true] foo: \'bar\' }');
var num = new Number(13.37); var num = new Number(13.37);
num.foo = 'bar'; num.foo = 'bar';
assert.equal(util.inspect(num), '{ [Number: 13.37] foo: \'bar\' }'); assert.equal(util.inspect(num), '{ [Number: 13.37] foo: \'bar\' }');
// test es6 Symbol
if (typeof Symbol !== 'undefined') {
assert.equal(util.inspect(Symbol()), 'Symbol()');
assert.equal(util.inspect(Symbol(123)), 'Symbol(123)');
assert.equal(util.inspect(Symbol('hi')), 'Symbol(hi)');
assert.equal(util.inspect([Symbol()]), '[ Symbol() ]');
assert.equal(util.inspect({ foo: Symbol() }), '{ foo: Symbol() }');
}