1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: replace string concatenation with template

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/16921
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This commit is contained in:
Jayashree S Kumar 2017-11-10 13:57:00 +05:30 committed by Franziska Hinkelmann
parent 79f805cce1
commit cb87c92694
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/_http_server.js
View File

@ -176,7 +176,7 @@ ServerResponse.prototype.detachSocket = function detachSocket(socket) {
}; };
ServerResponse.prototype.writeContinue = function writeContinue(cb) { ServerResponse.prototype.writeContinue = function writeContinue(cb) {
this._writeRaw('HTTP/1.1 100 Continue' + CRLF + CRLF, 'ascii', cb); this._writeRaw(`HTTP/1.1 100 Continue${CRLF}${CRLF}`, 'ascii', cb);
this._sent100 = true; this._sent100 = true;
}; };
@ -230,7 +230,7 @@ function writeHead(statusCode, reason, obj) {
if (checkInvalidHeaderChar(this.statusMessage)) if (checkInvalidHeaderChar(this.statusMessage))
throw new errors.Error('ERR_INVALID_CHAR', 'statusMessage'); throw new errors.Error('ERR_INVALID_CHAR', 'statusMessage');
var statusLine = 'HTTP/1.1 ' + statusCode + ' ' + this.statusMessage + CRLF; var statusLine = `HTTP/1.1 ${statusCode} ${this.statusMessage}${CRLF}`;
if (statusCode === 204 || statusCode === 304 || if (statusCode === 204 || statusCode === 304 ||
(statusCode >= 100 && statusCode <= 199)) { (statusCode >= 100 && statusCode <= 199)) {
@ -456,7 +456,7 @@ function onParserExecute(server, socket, parser, state, ret, d) {
} }
const badRequestResponse = Buffer.from( const badRequestResponse = Buffer.from(
'HTTP/1.1 400 ' + STATUS_CODES[400] + CRLF + CRLF, 'ascii' `HTTP/1.1 400 ${STATUS_CODES[400]}${CRLF}${CRLF}`, 'ascii'
); );
function socketOnError(e) { function socketOnError(e) {
// Ignore further errors // Ignore further errors