test: refactor test-stream-pipe-after-end
* replace `process.on('exit', ...)` checks with `common.mustCall()` * assert.equal() -> assert.strictEqual() * provide duration of 1ms to timer without a duration * remove unused function argument PR-URL: https://github.com/nodejs/node/pull/10483 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
This commit is contained in:
parent
508d97628b
commit
ca82f72b31
@ -1,5 +1,5 @@
|
|||||||
'use strict';
|
'use strict';
|
||||||
require('../common');
|
const common = require('../common');
|
||||||
const assert = require('assert');
|
const assert = require('assert');
|
||||||
const Readable = require('_stream_readable');
|
const Readable = require('_stream_readable');
|
||||||
const Writable = require('_stream_writable');
|
const Writable = require('_stream_writable');
|
||||||
@ -13,7 +13,7 @@ function TestReadable(opt) {
|
|||||||
this._ended = false;
|
this._ended = false;
|
||||||
}
|
}
|
||||||
|
|
||||||
TestReadable.prototype._read = function(n) {
|
TestReadable.prototype._read = function() {
|
||||||
if (this._ended)
|
if (this._ended)
|
||||||
this.emit('error', new Error('_read called twice'));
|
this.emit('error', new Error('_read called twice'));
|
||||||
this._ended = true;
|
this._ended = true;
|
||||||
@ -35,31 +35,18 @@ TestWritable.prototype._write = function(chunk, encoding, cb) {
|
|||||||
|
|
||||||
// this one should not emit 'end' until we read() from it later.
|
// this one should not emit 'end' until we read() from it later.
|
||||||
const ender = new TestReadable();
|
const ender = new TestReadable();
|
||||||
let enderEnded = false;
|
|
||||||
|
|
||||||
// what happens when you pipe() a Readable that's already ended?
|
// what happens when you pipe() a Readable that's already ended?
|
||||||
const piper = new TestReadable();
|
const piper = new TestReadable();
|
||||||
// pushes EOF null, and length=0, so this will trigger 'end'
|
// pushes EOF null, and length=0, so this will trigger 'end'
|
||||||
piper.read();
|
piper.read();
|
||||||
|
|
||||||
setTimeout(function() {
|
setTimeout(common.mustCall(function() {
|
||||||
ender.on('end', function() {
|
ender.on('end', common.mustCall(function() {}));
|
||||||
enderEnded = true;
|
|
||||||
});
|
|
||||||
assert(!enderEnded);
|
|
||||||
const c = ender.read();
|
const c = ender.read();
|
||||||
assert.equal(c, null);
|
assert.strictEqual(c, null);
|
||||||
|
|
||||||
const w = new TestWritable();
|
const w = new TestWritable();
|
||||||
let writableFinished = false;
|
w.on('finish', common.mustCall(function() {}));
|
||||||
w.on('finish', function() {
|
|
||||||
writableFinished = true;
|
|
||||||
});
|
|
||||||
piper.pipe(w);
|
piper.pipe(w);
|
||||||
|
}), 1);
|
||||||
process.on('exit', function() {
|
|
||||||
assert(enderEnded);
|
|
||||||
assert(writableFinished);
|
|
||||||
console.log('ok');
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user