1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test-console: streamline arrow fn and refine regex

Browse Source 
removed unneccessary curly braces and return statement from
inspect arrow function
updated `assert.throws` regex to look for exact match at start
of string

PR-URL: https://github.com/nodejs/node/pull/11039
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
John Maguire 2017-01-27 15:09:36 -05:00 committed by James M Snell
parent 78545039d6
commit ca3d131bd4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-console.js
View File

@ -22,7 +22,7 @@ assert.doesNotThrow(function() {
});
// an Object with a custom .inspect() function
const custom_inspect = { foo: 'bar', inspect: () => { return 'inspect'; } };
const custom_inspect = { foo: 'bar', inspect: () => 'inspect' };
const stdout_write = global.process.stdout.write;
const stderr_write = global.process.stderr.write;
@ -130,7 +130,7 @@ assert.strictEqual(errStrings.length, 0);
assert.throws(() => {
console.assert(false, 'should throw');
}, /should throw/);
}, /^AssertionError: should throw$/);
assert.doesNotThrow(() => {
console.assert(true, 'this should not throw');