1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: move addons message in Makefile

Browse Source 
Displaying a message about building addons before building docs can be
confusing when troubleshooting. (This just happened to me.) Move the
message about building addons to just before the step for building
addons.

PR-URL: https://github.com/nodejs/node/pull/23114
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Rich Trott 2018-09-26 21:32:37 -07:00
parent 3c56b46bfa
commit c9c4550dd4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -278,9 +278,9 @@ jstest: build-addons build-addons-napi ## Runs addon tests and JS tests
.PHONY: test .PHONY: test
# This does not run tests of third-party libraries inside deps. # This does not run tests of third-party libraries inside deps.
test: all ## Runs default tests, linters, and builds docs. test: all ## Runs default tests, linters, and builds docs.
$(MAKE) -s test-doc
@echo "Build the addons before running the tests so the test results" @echo "Build the addons before running the tests so the test results"
@echo "can be displayed together" @echo "can be displayed together"
$(MAKE) -s test-doc
$(MAKE) -s build-addons $(MAKE) -s build-addons
$(MAKE) -s build-addons-napi $(MAKE) -s build-addons-napi
$(MAKE) -s cctest $(MAKE) -s cctest