deps: fix wrong default for v8 handle zapping
PR-URL: https://github.com/nodejs/node/pull/23801 Fixes: https://github.com/nodejs/node/issues/23796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
This commit is contained in:
parent
d901d16b39
commit
c9b49a64fe
@ -33,7 +33,7 @@
|
||||
|
||||
# Reset this number to 0 on major V8 upgrades.
|
||||
# Increment by one for each non-official patch applied to deps/v8.
|
||||
'v8_embedder_string': '-node.5',
|
||||
'v8_embedder_string': '-node.6',
|
||||
|
||||
# Enable disassembler for `--print-code` v8 options
|
||||
'v8_enable_disassembler': 1,
|
||||
|
11
deps/v8/gypfiles/features.gypi
vendored
11
deps/v8/gypfiles/features.gypi
vendored
@ -103,7 +103,9 @@
|
||||
# Enable mitigations for executing untrusted code.
|
||||
'v8_untrusted_code_mitigations%': 'true',
|
||||
|
||||
'v8_enable_handle_zapping%': 1,
|
||||
# Currently set for node by common.gypi, avoiding default because of gyp file bug.
|
||||
# Should be turned on only for debugging.
|
||||
#'v8_enable_handle_zapping%': 0,
|
||||
},
|
||||
'target_defaults': {
|
||||
'conditions': [
|
||||
@ -164,9 +166,10 @@
|
||||
['v8_untrusted_code_mitigations=="false"', {
|
||||
'defines': ['DISABLE_UNTRUSTED_CODE_MITIGATIONS',],
|
||||
}],
|
||||
['v8_enable_handle_zapping==1', {
|
||||
'defines': ['ENABLE_HANDLE_ZAPPING',],
|
||||
}],
|
||||
# Refs: https://github.com/nodejs/node/pull/23801
|
||||
# ['v8_enable_handle_zapping==1', {
|
||||
# 'defines': ['ENABLE_HANDLE_ZAPPING',],
|
||||
# }],
|
||||
], # conditions
|
||||
'defines': [
|
||||
'V8_GYP_BUILD',
|
||||
|
6
deps/v8/gypfiles/toolchain.gypi
vendored
6
deps/v8/gypfiles/toolchain.gypi
vendored
@ -1321,6 +1321,10 @@
|
||||
}, {
|
||||
'inherit_from': ['DebugBase1'],
|
||||
}],
|
||||
# Temporary refs: https://github.com/nodejs/node/pull/23801
|
||||
['v8_enable_handle_zapping==1', {
|
||||
'defines': ['ENABLE_HANDLE_ZAPPING',],
|
||||
}],
|
||||
],
|
||||
}, # Debug
|
||||
'ReleaseBase': {
|
||||
@ -1405,6 +1409,8 @@
|
||||
}, # Release
|
||||
'Release': {
|
||||
'inherit_from': ['ReleaseBase'],
|
||||
# Temporary refs: https://github.com/nodejs/node/pull/23801
|
||||
'defines!': ['ENABLE_HANDLE_ZAPPING',],
|
||||
}, # Debug
|
||||
'conditions': [
|
||||
[ 'OS=="win"', {
|
||||
|
Loading…
x
Reference in New Issue
Block a user