test: refactor parallel/test-tls-pause

Use arrow functions and common.mustCall() and add a description.

PR-URL: https://github.com/nodejs/node/pull/18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
juggernaut451 2018-02-11 21:39:05 +05:30 committed by Ruben Bridgewater
parent ef7f5a11e8
commit c9b42c4c13
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762

View File

@ -24,6 +24,9 @@ const common = require('../common');
if (!common.hasCrypto) if (!common.hasCrypto)
common.skip('missing crypto'); common.skip('missing crypto');
// This test ensures that the data received over tls-server after pause
// is same as what it was sent
const assert = require('assert'); const assert = require('assert');
const tls = require('tls'); const tls = require('tls');
const fixtures = require('../common/fixtures'); const fixtures = require('../common/fixtures');
@ -37,24 +40,23 @@ const bufSize = 1024 * 1024;
let sent = 0; let sent = 0;
let received = 0; let received = 0;
const server = tls.Server(options, function(socket) { const server = tls.Server(options, common.mustCall((socket) => {
socket.pipe(socket); socket.pipe(socket);
socket.on('data', function(c) { socket.on('data', (c) => {
console.error('data', c.length); console.error('data', c.length);
}); });
}); }));
server.listen(0, function() { server.listen(0, common.mustCall(() => {
let resumed = false; let resumed = false;
const client = tls.connect({ const client = tls.connect({
port: this.address().port, port: server.address().port,
rejectUnauthorized: false rejectUnauthorized: false
}, function() { }, common.mustCall(() => {
console.error('connected'); console.error('connected');
client.pause(); client.pause();
console.error('paused'); console.error('paused');
send(); const send = (() => {
function send() {
console.error('sending'); console.error('sending');
const ret = client.write(Buffer.allocUnsafe(bufSize)); const ret = client.write(Buffer.allocUnsafe(bufSize));
console.error(`write => ${ret}`); console.error(`write => ${ret}`);
@ -69,9 +71,9 @@ server.listen(0, function() {
resumed = true; resumed = true;
client.resume(); client.resume();
console.error('resumed', client); console.error('resumed', client);
} })();
}); }));
client.on('data', function(data) { client.on('data', (data) => {
console.error('data'); console.error('data');
assert.ok(resumed); assert.ok(resumed);
received += data.length; received += data.length;
@ -83,8 +85,8 @@ server.listen(0, function() {
server.close(); server.close();
} }
}); });
}); }));
process.on('exit', function() { process.on('exit', () => {
assert.strictEqual(sent, received); assert.strictEqual(sent, received);
}); });