1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix order of assert.strictEqual() args to actual, expected

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/23501
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Joshua Belcher 2018-10-12 10:10:15 -07:00 committed by Ruben Bridgewater
parent 179c3a8f04
commit c95707f56e
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
test/addons-napi/test_make_callback/test.js
View File

@ -13,22 +13,21 @@ function myMultiArgFunc(arg1, arg2, arg3) {
return 42; return 42;
} }
assert.strictEqual(42, makeCallback(process, common.mustCall(function() { assert.strictEqual(makeCallback(process, common.mustCall(function() {
assert.strictEqual(0, arguments.length); assert.strictEqual(0, arguments.length);
assert.strictEqual(this, process); assert.strictEqual(this, process);
return 42; return 42;
}))); })), 42);
assert.strictEqual(42, makeCallback(process, common.mustCall(function(x) { assert.strictEqual(makeCallback(process, common.mustCall(function(x) {
assert.strictEqual(1, arguments.length); assert.strictEqual(arguments.length, 1);
assert.strictEqual(this, process); assert.strictEqual(this, process);
assert.strictEqual(x, 1337); assert.strictEqual(x, 1337);
return 42; return 42;
}), 1337)); }), 1337), 42);
assert.strictEqual(42, assert.strictEqual(makeCallback(this,
makeCallback(this, common.mustCall(myMultiArgFunc), 1, 2, 3), 42);
common.mustCall(myMultiArgFunc), 1, 2, 3));
// TODO(node-api): napi_make_callback needs to support // TODO(node-api): napi_make_callback needs to support
// strings passed for the func argument // strings passed for the func argument
@ -47,12 +46,12 @@ const recv = {
}), }),
}; };
assert.strictEqual(42, makeCallback(recv, 'one')); assert.strictEqual(makeCallback(recv, 'one'), 42);
assert.strictEqual(42, makeCallback(recv, 'two', 1337)); assert.strictEqual(makeCallback(recv, 'two', 1337), 42);
// Check that callbacks on a receiver from a different context works. // Check that callbacks on a receiver from a different context works.
const foreignObject = vm.runInNewContext('({ fortytwo() { return 42; } })'); const foreignObject = vm.runInNewContext('({ fortytwo() { return 42; } })');
assert.strictEqual(42, makeCallback(foreignObject, 'fortytwo')); assert.strictEqual(makeCallback(foreignObject, 'fortytwo'), 42);
*/ */
// Check that the callback is made in the context of the receiver. // Check that the callback is made in the context of the receiver.
@ -63,7 +62,7 @@ const target = vm.runInNewContext(`
return Object; return Object;
}) })
`); `);
assert.notStrictEqual(Object, makeCallback(process, target, Object)); assert.notStrictEqual(makeCallback(process, target, Object), Object);
// Runs in inner context. // Runs in inner context.
const forward = vm.runInNewContext(` const forward = vm.runInNewContext(`
@ -79,4 +78,4 @@ function endpoint($Object) {
return Object; return Object;
} }
assert.strictEqual(Object, makeCallback(process, forward, endpoint)); assert.strictEqual(makeCallback(process, forward, endpoint), Object);