1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-domain

Browse Source 
Use assert.strictEqual() instead of assert.equal().

PR-URL: https://github.com/nodejs/node/pull/9890
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Johnny Reading 2016-12-01 10:11:46 -06:00 committed by Rich Trott
parent 2b293b7dc5
commit c8da009fb7
1 changed files with 34 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
test/parallel/test-domain.js
View File

@ -31,67 +31,67 @@ d.on('error', function(er) {
switch (er_message) { switch (er_message) {
case 'emitted': case 'emitted':
assert.equal(er.domain, d); assert.strictEqual(er.domain, d);
assert.equal(er.domainEmitter, e); assert.strictEqual(er.domainEmitter, e);
assert.equal(er.domainThrown, false); assert.strictEqual(er.domainThrown, false);
break; break;
case 'bound': case 'bound':
assert.ok(!er.domainEmitter); assert.ok(!er.domainEmitter);
assert.equal(er.domain, d); assert.strictEqual(er.domain, d);
assert.equal(er.domainBound, fn); assert.strictEqual(er.domainBound, fn);
assert.equal(er.domainThrown, false); assert.strictEqual(er.domainThrown, false);
break; break;
case 'thrown': case 'thrown':
assert.ok(!er.domainEmitter); assert.ok(!er.domainEmitter);
assert.equal(er.domain, d); assert.strictEqual(er.domain, d);
assert.equal(er.domainThrown, true); assert.strictEqual(er.domainThrown, true);
break; break;
case "ENOENT: no such file or directory, open 'this file does not exist'": case "ENOENT: no such file or directory, open 'this file does not exist'":
assert.equal(er.domain, d); assert.strictEqual(er.domain, d);
assert.equal(er.domainThrown, false); assert.strictEqual(er.domainThrown, false);
assert.equal(typeof er.domainBound, 'function'); assert.strictEqual(typeof er.domainBound, 'function');
assert.ok(!er.domainEmitter); assert.ok(!er.domainEmitter);
assert.equal(er.code, 'ENOENT'); assert.strictEqual(er.code, 'ENOENT');
assert.equal(er_path, 'this file does not exist'); assert.strictEqual(er_path, 'this file does not exist');
assert.equal(typeof er.errno, 'number'); assert.strictEqual(typeof er.errno, 'number');
break; break;
case case
"ENOENT: no such file or directory, open 'stream for nonexistent file'": "ENOENT: no such file or directory, open 'stream for nonexistent file'":
assert.equal(typeof er.errno, 'number'); assert.strictEqual(typeof er.errno, 'number');
assert.equal(er.code, 'ENOENT'); assert.strictEqual(er.code, 'ENOENT');
assert.equal(er_path, 'stream for nonexistent file'); assert.strictEqual(er_path, 'stream for nonexistent file');
assert.equal(er.domain, d); assert.strictEqual(er.domain, d);
assert.equal(er.domainEmitter, fst); assert.strictEqual(er.domainEmitter, fst);
assert.ok(!er.domainBound); assert.ok(!er.domainBound);
assert.equal(er.domainThrown, false); assert.strictEqual(er.domainThrown, false);
break; break;
case 'implicit': case 'implicit':
assert.equal(er.domainEmitter, implicit); assert.strictEqual(er.domainEmitter, implicit);
assert.equal(er.domain, d); assert.strictEqual(er.domain, d);
assert.equal(er.domainThrown, false); assert.strictEqual(er.domainThrown, false);
assert.ok(!er.domainBound); assert.ok(!er.domainBound);
break; break;
case 'implicit timer': case 'implicit timer':
assert.equal(er.domain, d); assert.strictEqual(er.domain, d);
assert.equal(er.domainThrown, true); assert.strictEqual(er.domainThrown, true);
assert.ok(!er.domainEmitter); assert.ok(!er.domainEmitter);
assert.ok(!er.domainBound); assert.ok(!er.domainBound);
break; break;
case 'Cannot read property \'isDirectory\' of undefined': case 'Cannot read property \'isDirectory\' of undefined':
assert.equal(er.domain, d); assert.strictEqual(er.domain, d);
assert.ok(!er.domainEmitter); assert.ok(!er.domainEmitter);
assert.ok(!er.domainBound); assert.ok(!er.domainBound);
break; break;
case 'nextTick execution loop': case 'nextTick execution loop':
assert.equal(er.domain, d); assert.strictEqual(er.domain, d);
assert.ok(!er.domainEmitter); assert.ok(!er.domainEmitter);
assert.ok(!er.domainBound); assert.ok(!er.domainBound);
break; break;
@ -107,7 +107,8 @@ d.on('error', function(er) {
process.on('exit', function() { process.on('exit', function() {
console.error('exit', caught, expectCaught); console.error('exit', caught, expectCaught);
assert.equal(caught, expectCaught, 'caught the expected number of errors'); assert.strictEqual(caught, expectCaught,
'caught the expected number of errors');
console.log('ok'); console.log('ok');
}); });
@ -172,7 +173,7 @@ expectCaught++;
// intercepted should never pass first argument to callback // intercepted should never pass first argument to callback
function fn2(data) { function fn2(data) {
assert.equal(data, 'data', 'should not be null err argument'); assert.strictEqual(data, 'data', 'should not be null err argument');
} }
bound = d.intercept(fn2); bound = d.intercept(fn2);
@ -181,8 +182,8 @@ bound(null, 'data');
// intercepted should never pass first argument to callback // intercepted should never pass first argument to callback
// even if arguments length is more than 2. // even if arguments length is more than 2.
function fn3(data, data2) { function fn3(data, data2) {
assert.equal(data, 'data', 'should not be null err argument'); assert.strictEqual(data, 'data', 'should not be null err argument');
assert.equal(data2, 'data2', 'should not be data argument'); assert.strictEqual(data2, 'data2', 'should not be data argument');
} }
bound = d.intercept(fn3); bound = d.intercept(fn3);
@ -225,14 +226,14 @@ expectCaught++;
var result = d.run(function() { var result = d.run(function() {
return 'return value'; return 'return value';
}); });
assert.equal(result, 'return value'); assert.strictEqual(result, 'return value');
// check if the executed function take in count the applied parameters // check if the executed function take in count the applied parameters
result = d.run(function(a, b) { result = d.run(function(a, b) {
return a + ' ' + b; return a + ' ' + b;
}, 'return', 'value'); }, 'return', 'value');
assert.equal(result, 'return value'); assert.strictEqual(result, 'return value');
var fst = fs.createReadStream('stream for nonexistent file'); var fst = fs.createReadStream('stream for nonexistent file');