1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "readline: clean up event listener in onNewListener"

Browse Source 
This reverts commit 81ddeb98f6a0f7a5165cd6e3b87cdaa550fdf3ec.

Ref: https://github.com/nodejs/node/pull/13266
PR-URL: https://github.com/nodejs/node/pull/13560
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Anna Henningsen 2017-06-08 23:13:11 +02:00
parent 2529119680
commit c6f074f737
No known key found for this signature in database
GPG Key ID: D8B9F5AEAE84E4CF
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/readline.js
View File

@ -1039,9 +1039,6 @@ function emitKeypressEvents(stream, iface) {
} else {
stream.on('newListener', onNewListener);
}
if (iface) {
iface.once('close', () => { stream.removeListener('data', onData); });
}
}
/**

6
test/parallel/test-readline-set-raw-mode.js
View File

@ -74,8 +74,6 @@ assert(!rawModeCalled);
assert(resumeCalled);
assert(!pauseCalled);
// One data listener for the keypress events.
assert.strictEqual(stream.listeners('data').length, 1);
// close() should call setRawMode(false)
expectedRawMode = false;
@ -88,5 +86,5 @@ assert(!resumeCalled);
assert(pauseCalled);
assert.deepStrictEqual(stream.listeners('keypress'), []);
// Data listener is removed once interface is closed.
assert.strictEqual(stream.listeners('data').length, 0);
// one data listener for the keypress events.
assert.strictEqual(stream.listeners('data').length, 1);