1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve test-stream2-large-read-stall

Browse Source 
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use  common.mustCall instead of process.on( 'exit', fn )

PR-URL: https://github.com/nodejs/node/pull/10725
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
This commit is contained in:
stefan judis 2017-01-10 17:38:48 +01:00 committed by Italo A. Casas
parent c963094f3c
commit c685638986
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/parallel/test-stream2-large-read-stall.js
View File

@ -33,7 +33,9 @@ r.on('readable', function() {
rs.length); rs.length);
}); });
r.on('end', common.mustCall(function() {})); r.on('end', common.mustCall(function() {
assert.strictEqual(pushes, PUSHCOUNT + 1);
}));
let pushes = 0; let pushes = 0;
function push() { function push() {
@ -49,7 +51,3 @@ function push() {
if (r.push(Buffer.allocUnsafe(PUSHSIZE))) if (r.push(Buffer.allocUnsafe(PUSHSIZE)))
setTimeout(push, 1); setTimeout(push, 1);
} }
process.on('exit', function() {
assert.strictEqual(pushes, PUSHCOUNT + 1);
});