src: remove calls to SetWrapperClassId()

We have migrated from the deprecated RetainedObjectInfo API to
the new EmbedderGraph API, so there is no need to take care
of wrapper class ids anymore since they are dedicated to the
deprecated API (the new API uses a graph instead of ids to retrieve
info about nodes).

PR-URL: https://github.com/nodejs/node/pull/22975
Refs: https://github.com/nodejs/node/pull/21741
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Joyee Cheung 2018-09-20 12:13:39 -04:00
parent de0441f6f6
commit c67d3d0c3c
No known key found for this signature in database
GPG Key ID: 92B78A53C8303B8D
3 changed files with 0 additions and 8 deletions

View File

@ -556,9 +556,6 @@ AsyncWrap::AsyncWrap(Environment* env,
CHECK_NE(provider, PROVIDER_NONE);
CHECK_GE(object->InternalFieldCount(), 1);
// Shift provider value over to prevent id collision.
persistent().SetWrapperClassId(NODE_ASYNC_ID_OFFSET + provider_type_);
// Use AsyncReset() call to execute the init() callbacks.
AsyncReset(execution_async_id, silent);
}

View File

@ -31,8 +31,6 @@
namespace node {
#define NODE_ASYNC_ID_OFFSET 0xA1C
#define NODE_ASYNC_NON_CRYPTO_PROVIDER_TYPES(V) \
V(NONE) \
V(DNSCHANNEL) \

View File

@ -33,8 +33,6 @@
#include <string.h>
#include <limits.h>
#define BUFFER_ID 0xB0E4
#define MIN(a, b) ((a) < (b) ? (a) : (b))
#define THROW_AND_RETURN_UNLESS_BUFFER(env, obj) \
@ -144,7 +142,6 @@ CallbackInfo::CallbackInfo(Isolate* isolate,
CHECK_NOT_NULL(data_);
persistent_.SetWeak(this, WeakCallback, v8::WeakCallbackType::kParameter);
persistent_.SetWrapperClassId(BUFFER_ID);
isolate->AdjustAmountOfExternalAllocatedMemory(sizeof(*this));
}