1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: elevate v8 namespaces for node_url.cc

Browse Source 
Elevate namespace for repeated entities.

PR-URL: https://github.com/nodejs/node/pull/24573
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Jayasankar 2018-11-23 06:26:31 +05:30 committed by Rich Trott
parent 63aef2d193
commit c5db2df325
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/node_url.cc
View File

@ -21,6 +21,7 @@ using v8::Integer;
using v8::Isolate; using v8::Isolate;
using v8::Local; using v8::Local;
using v8::MaybeLocal; using v8::MaybeLocal;
using v8::NewStringType;
using v8::Null; using v8::Null;
using v8::Object; using v8::Object;
using v8::String; using v8::String;
@ -31,7 +32,7 @@ using v8::Value;
inline Local<String> Utf8String(Isolate* isolate, const std::string& str) { inline Local<String> Utf8String(Isolate* isolate, const std::string& str) {
return String::NewFromUtf8(isolate, return String::NewFromUtf8(isolate,
str.data(), str.data(),
v8::NewStringType::kNormal, NewStringType::kNormal,
str.length()).ToLocalChecked(); str.length()).ToLocalChecked();
} }
@ -2159,7 +2160,7 @@ static void Parse(Environment* env,
argv[ERR_ARG_INPUT] = argv[ERR_ARG_INPUT] =
String::NewFromUtf8(env->isolate(), String::NewFromUtf8(env->isolate(),
input, input,
v8::NewStringType::kNormal).ToLocalChecked(); NewStringType::kNormal).ToLocalChecked();
error_cb.As<Function>()->Call(context, recv, arraysize(argv), argv) error_cb.As<Function>()->Call(context, recv, arraysize(argv), argv)
.FromMaybe(Local<Value>()); .FromMaybe(Local<Value>());
} }
@ -2209,7 +2210,7 @@ static void EncodeAuthSet(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set( args.GetReturnValue().Set(
String::NewFromUtf8(env->isolate(), String::NewFromUtf8(env->isolate(),
output.c_str(), output.c_str(),
v8::NewStringType::kNormal).ToLocalChecked()); NewStringType::kNormal).ToLocalChecked());
} }
static void ToUSVString(const FunctionCallbackInfo<Value>& args) { static void ToUSVString(const FunctionCallbackInfo<Value>& args) {
@ -2243,7 +2244,7 @@ static void ToUSVString(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set( args.GetReturnValue().Set(
String::NewFromTwoByte(env->isolate(), String::NewFromTwoByte(env->isolate(),
*value, *value,
v8::NewStringType::kNormal, NewStringType::kNormal,
n).ToLocalChecked()); n).ToLocalChecked());
} }
@ -2264,7 +2265,7 @@ static void DomainToASCII(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set( args.GetReturnValue().Set(
String::NewFromUtf8(env->isolate(), String::NewFromUtf8(env->isolate(),
out.c_str(), out.c_str(),
v8::NewStringType::kNormal).ToLocalChecked()); NewStringType::kNormal).ToLocalChecked());
} }
static void DomainToUnicode(const FunctionCallbackInfo<Value>& args) { static void DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
@ -2284,7 +2285,7 @@ static void DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set( args.GetReturnValue().Set(
String::NewFromUtf8(env->isolate(), String::NewFromUtf8(env->isolate(),
out.c_str(), out.c_str(),
v8::NewStringType::kNormal).ToLocalChecked()); NewStringType::kNormal).ToLocalChecked());
} }
std::string URL::ToFilePath() const { std::string URL::ToFilePath() const {