1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add test of fs.promises write for non-string buffers

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/21708
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Ryuichi Sakagami 2018-07-08 19:09:18 +09:00 committed by Anna Henningsen
parent 8babbc5e45
commit c596eb2673
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/parallel/test-fs-promises-file-handle-write.js
View File

@ -45,8 +45,22 @@ async function validateNonUint8ArrayWrite() {
assert.deepStrictEqual(Buffer.from(buffer, 'utf8'), readFileData); assert.deepStrictEqual(Buffer.from(buffer, 'utf8'), readFileData);
} }
async function validateNonStringValuesWrite() {
const filePathForHandle = path.resolve(tmpDir, 'tmp-non-string-write.txt');
const fileHandle = await open(filePathForHandle, 'w+');
const nonStringValues = [123, {}, new Map()];
for (const nonStringValue of nonStringValues) {
await fileHandle.write(nonStringValue);
}
const readFileData = fs.readFileSync(filePathForHandle);
const expected = ['123', '[object Object]', '[object Map]'].join('');
assert.deepStrictEqual(Buffer.from(expected, 'utf8'), readFileData);
}
Promise.all([ Promise.all([
validateWrite(), validateWrite(),
validateEmptyWrite(), validateEmptyWrite(),
validateNonUint8ArrayWrite() validateNonUint8ArrayWrite(),
validateNonStringValuesWrite()
]).then(common.mustCall()); ]).then(common.mustCall());