1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tools: simplify ESLint invocation in Makefile

Browse Source 
Makefile currently enforces .eslintrc.js linting on the command line but
it is already enforced in the .estlintignore file.

This also simplifies an arguably-related comment in .estlinrc.js.

PR-URL: https://github.com/nodejs/node/pull/22348
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Rich Trott 2018-08-15 20:32:58 -07:00
parent 892932f9bd
commit c535bde5da
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.eslintrc.js
View File

@ -187,7 +187,7 @@ module.exports = {
message: 'Use new keyword when throwing an Error.', message: 'Use new keyword when throwing an Error.',
} }
], ],
/* eslint-enable max-len, quotes */ /* eslint-enable max-len */
'no-return-await': 'error', 'no-return-await': 'error',
'no-self-assign': 'error', 'no-self-assign': 'error',
'no-self-compare': 'error', 'no-self-compare': 'error',

2
Makefile
View File

@ -1120,7 +1120,7 @@ endif
LINT_JS_TARGETS = .eslintrc.js benchmark doc lib test tools LINT_JS_TARGETS = .eslintrc.js benchmark doc lib test tools
run-lint-js = tools/node_modules/eslint/bin/eslint.js --cache \ run-lint-js = tools/node_modules/eslint/bin/eslint.js --cache \
--ext=.js,.mjs,.md $(LINT_JS_TARGETS) --ignore-pattern '!.eslintrc.js' --ext=.js,.mjs,.md $(LINT_JS_TARGETS)
run-lint-js-fix = $(run-lint-js) --fix run-lint-js-fix = $(run-lint-js) --fix
.PHONY: lint-js-fix .PHONY: lint-js-fix