1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: fix potential memory leak on early return

Browse Source
This commit is contained in:
mscdex 2013-04-20 23:21:13 -04:00 committed by Fedor Indutny
parent 2322580dfb
commit c4379a5554
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/node_crypto.cc
View File

@ -3009,9 +3009,6 @@ class Sign : public ObjectWrap {
unsigned int md_len; unsigned int md_len;
Local<Value> outString; Local<Value> outString;
md_len = 8192; // Maximum key size is 8192 bits
md_value = new unsigned char[md_len];
ASSERT_IS_BUFFER(args[0]); ASSERT_IS_BUFFER(args[0]);
ssize_t len = Buffer::Length(args[0]); ssize_t len = Buffer::Length(args[0]);
@ -3019,6 +3016,9 @@ class Sign : public ObjectWrap {
ssize_t written = DecodeWrite(buf, len, args[0], BUFFER); ssize_t written = DecodeWrite(buf, len, args[0], BUFFER);
assert(written == len); assert(written == len);
md_len = 8192; // Maximum key size is 8192 bits
md_value = new unsigned char[md_len];
int r = sign->SignFinal(&md_value, &md_len, buf, len); int r = sign->SignFinal(&md_value, &md_len, buf, len);
if (r == 0) { if (r == 0) {
md_value = NULL; md_value = NULL;