1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor cluster-net-listen-relative-path

Browse Source 
Refactor test-cluster-net-listen-relative-path:

* Use arrow funcitons for callbacks.
* Move skip-test code closer to start of file.
* Use assert.ok() where appropriate.
* Capitalize and punctuate comments.

PR-URL: https://github.com/nodejs/node/pull/21863
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Rich Trott 2018-07-17 22:40:55 -07:00
parent 6ca5a8ac0c
commit c3f8dd6f98
1 changed files with 17 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
test/parallel/test-cluster-net-listen-relative-path.js
View File

@ -1,12 +1,5 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
const assert = require('assert');
const cluster = require('cluster');
const net = require('net');
const path = require('path');
const fs = require('fs');
const tmpdir = require('../common/tmpdir');
if (common.isWindows) if (common.isWindows)
common.skip('On Windows named pipes live in their own ' + common.skip('On Windows named pipes live in their own ' +
@ -14,35 +7,40 @@ if (common.isWindows)
if (!common.isMainThread) if (!common.isMainThread)
common.skip('process.chdir is not available in Workers'); common.skip('process.chdir is not available in Workers');
const assert = require('assert');
const cluster = require('cluster');
const fs = require('fs');
const net = require('net');
const path = require('path');
const tmpdir = require('../common/tmpdir');
// Choose a socket name such that the absolute path would exceed 100 bytes. // Choose a socket name such that the absolute path would exceed 100 bytes.
const socketDir = './unix-socket-dir'; const socketDir = './unix-socket-dir';
const socketName = 'A'.repeat(100 - socketDir.length - 1); const socketName = 'A'.repeat(100 - socketDir.length - 1);
// Make sure we're not in a weird environment // Make sure we're not in a weird environment.
assert.strictEqual(path.resolve(socketDir, socketName).length > 100, true, assert.ok(path.resolve(socketDir, socketName).length > 100,
'absolute socket path should be longer than 100 bytes'); 'absolute socket path should be longer than 100 bytes');
if (cluster.isMaster) { if (cluster.isMaster) {
// ensure that the worker exits peacefully // Ensure that the worker exits peacefully.
tmpdir.refresh(); tmpdir.refresh();
process.chdir(tmpdir.path); process.chdir(tmpdir.path);
fs.mkdirSync(socketDir); fs.mkdirSync(socketDir);
cluster.fork().on('exit', common.mustCall(function(statusCode) { cluster.fork().on('exit', common.mustCall((statusCode) => {
assert.strictEqual(statusCode, 0); assert.strictEqual(statusCode, 0);
assert.strictEqual( assert.ok(!fs.existsSync(path.join(socketDir, socketName)),
fs.existsSync(path.join(socketDir, socketName)), false, 'Socket should be removed when the worker exits');
'Socket should be removed when the worker exits');
})); }));
} else { } else {
process.chdir(socketDir); process.chdir(socketDir);
const server = net.createServer(common.mustNotCall()); const server = net.createServer(common.mustNotCall());
server.listen(socketName, common.mustCall(function() { server.listen(socketName, common.mustCall(() => {
assert.strictEqual( assert.ok(fs.existsSync(socketName), 'Socket created in CWD');
fs.existsSync(socketName), true,
'Socket created in CWD');
process.disconnect(); process.disconnect();
})); }));