1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky test-vm-timeout-rethrow

Browse Source 
The intention of test case is to make sure that `timeout` property is honored
and the code in context terminates and throws correct exception. However in
test case, the code inside context would complete before `timeout` for windows
and would sometimes fail. Updated the code so it guarantee to not complete
execution until timeout is triggered.

Fixes: https://github.com/nodejs/node/issues/11261
PR-URL: https://github.com/nodejs/node/pull/11530
Reviewed-By: James M Snell <jasnell.gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
This commit is contained in:
Kunal Pathak 2017-02-23 18:18:48 -08:00 committed by Josh Gavant
parent 6eb614adc8
commit c3bc48f632
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/sequential/test-vm-timeout-rethrow.js
View File

@ -5,15 +5,9 @@ const vm = require('vm');
const spawn = require('child_process').spawn;
if (process.argv[2] === 'child') {
const code = 'let j = 0;\n' +
'for (let i = 0; i < 1000000; i++) j += add(i, i + 1);\n' +
'j;';
const code = 'while(true);';
const ctx = vm.createContext({
add: function(x, y) {
return x + y;
}
});
const ctx = vm.createContext();
vm.runInContext(code, ctx, { timeout: 1 });
} else {