1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix assert.strictEqual() parameter order in test-path-maklong.js

Browse Source 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

PR-URL: https://github.com/nodejs/node/pull/23587
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
blakehall 2018-10-12 11:22:53 -07:00 committed by Ruben Bridgewater
parent c8986bb7a3
commit c30658c11e
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
test/parallel/test-path-makelong.js
View File

@ -29,17 +29,18 @@ if (common.isWindows) {
const file = fixtures.path('a.js'); const file = fixtures.path('a.js');
const resolvedFile = path.resolve(file); const resolvedFile = path.resolve(file);
assert.strictEqual(`\\\\?\\${resolvedFile}`, assert.strictEqual(path.toNamespacedPath(file),
path.toNamespacedPath(file)); `\\\\?\\${resolvedFile}`);
assert.strictEqual(`\\\\?\\${resolvedFile}`, assert.strictEqual(path.toNamespacedPath(`\\\\?\\${file}`),
path.toNamespacedPath(`\\\\?\\${file}`)); `\\\\?\\${resolvedFile}`);
assert.strictEqual('\\\\?\\UNC\\someserver\\someshare\\somefile', assert.strictEqual(path.toNamespacedPath(
path.toNamespacedPath( '\\\\someserver\\someshare\\somefile'),
'\\\\someserver\\someshare\\somefile')); '\\\\?\\UNC\\someserver\\someshare\\somefile');
assert.strictEqual('\\\\?\\UNC\\someserver\\someshare\\somefile', path assert.strictEqual(path.toNamespacedPath(
.toNamespacedPath('\\\\?\\UNC\\someserver\\someshare\\somefile')); '\\\\?\\UNC\\someserver\\someshare\\somefile'),
assert.strictEqual('\\\\.\\pipe\\somepipe', '\\\\?\\UNC\\someserver\\someshare\\somefile');
path.toNamespacedPath('\\\\.\\pipe\\somepipe')); assert.strictEqual(path.toNamespacedPath('\\\\.\\pipe\\somepipe'),
'\\\\.\\pipe\\somepipe');
} }
assert.strictEqual(path.toNamespacedPath(null), null); assert.strictEqual(path.toNamespacedPath(null), null);