1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

errors: provide defaults for unmapped uv errors

Browse Source 
libuv does not map 100% of errors. When an unmapped error is
encountered, the Map returns undefined, which is then
unsuccessfully destructured, causing an exception. This commit
adds a default value in the event of an unmapped error.

PR-URL: https://github.com/nodejs/node/pull/29288
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
cjihrig 2019-08-23 16:43:17 -04:00 committed by Rich Trott
parent 5ba3a2c4b6
commit c246f813f8
2 changed files with 30 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/internal/errors.js
View File

@ -327,6 +327,8 @@ function lazyUv() {
return uvBinding;
}
const uvUnmappedError = ['UNKNOWN', 'unknown error'];
function uvErrmapGet(name) {
uvBinding = lazyUv();
if (!uvBinding.errmap) {
@ -346,7 +348,7 @@ function uvErrmapGet(name) {
* @returns {Error}
*/
function uvException(ctx) {
const [ code, uvmsg ] = uvErrmapGet(ctx.errno);
const [ code, uvmsg ] = uvErrmapGet(ctx.errno) || uvUnmappedError;
let message = `${code}: ${ctx.message || uvmsg}, ${ctx.syscall}`;
let path;
@ -404,7 +406,7 @@ function uvException(ctx) {
* @returns {Error}
*/
function uvExceptionWithHostPort(err, syscall, address, port) {
const [ code, uvmsg ] = uvErrmapGet(err);
const [ code, uvmsg ] = uvErrmapGet(err) || uvUnmappedError;
const message = `${syscall} ${code}: ${uvmsg}`;
let details = '';

26
test/parallel/test-uv-unmapped-exception.js Normal file
View File

@ -0,0 +1,26 @@
// Flags: --expose-internals
'use strict';
require('../common');
const assert = require('assert');
const { uvException, uvExceptionWithHostPort } = require('internal/errors');
{
const exception = uvException({ errno: 100, syscall: 'open' });
assert.strictEqual(exception.message, 'UNKNOWN: unknown error, open');
assert.strictEqual(exception.errno, 100);
assert.strictEqual(exception.syscall, 'open');
assert.strictEqual(exception.code, 'UNKNOWN');
}
{
const exception = uvExceptionWithHostPort(100, 'listen', '127.0.0.1', 80);
assert.strictEqual(exception.message,
'listen UNKNOWN: unknown error 127.0.0.1:80');
assert.strictEqual(exception.code, 'UNKNOWN');
assert.strictEqual(exception.errno, 100);
assert.strictEqual(exception.syscall, 'listen');
assert.strictEqual(exception.address, '127.0.0.1');
assert.strictEqual(exception.port, 80);
}