test: enable marking of failing coverage tests
Enable marking of coverage tests so that we can allow some tests to fail without blocking the generation of coverage data. This will later allow us to fail the coverage job if other kinds of errors occur and to capture which tests we believe are not running properly with coverage enabled. PR-URL: https://github.com/nodejs/node/pull/25671 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
This commit is contained in:
parent
78982389ce
commit
c06653efdb
5
Makefile
5
Makefile
@ -226,7 +226,8 @@ coverage-test: coverage-build
|
||||
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/gen/*.gcda
|
||||
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/*.gcda
|
||||
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/tracing/*.gcda
|
||||
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage $(MAKE) $(COVTESTS)
|
||||
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage \
|
||||
TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) $(COVTESTS)
|
||||
$(MAKE) coverage-report-js
|
||||
-(cd out && "../gcovr/scripts/gcovr" --gcov-exclude='.*deps' \
|
||||
--gcov-exclude='.*usr' -v -r Release/obj.target \
|
||||
@ -277,7 +278,7 @@ coverage-run-js:
|
||||
$(RM) -r out/$(BUILDTYPE)/.coverage
|
||||
$(MAKE) coverage-build-js
|
||||
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage CI_SKIP_TESTS=$(COV_SKIP_TESTS) \
|
||||
$(MAKE) jstest
|
||||
TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) jstest
|
||||
$(MAKE) coverage-report-js
|
||||
|
||||
.PHONY: test
|
||||
|
@ -159,3 +159,7 @@ sequential/test-inspector-port-cluster: SLOW
|
||||
sequential/test-net-bytes-per-incoming-chunk-overhead: SLOW
|
||||
sequential/test-pipe: SLOW
|
||||
sequential/test-util-debug: SLOW
|
||||
|
||||
[$type==coverage]
|
||||
js-native-api/test_function/test: PASS,FAIL,CRASH
|
||||
js-native-api/test_general/testFinalizer: PASS,FAIL,CRASH
|
||||
|
@ -1391,7 +1391,7 @@ def BuildOptions():
|
||||
help='Send SIGABRT instead of SIGTERM to kill processes that time out',
|
||||
default=False, action="store_true", dest="abort_on_timeout")
|
||||
result.add_option("--type",
|
||||
help="Type of build (simple, fips)",
|
||||
help="Type of build (simple, fips, coverage)",
|
||||
default=None)
|
||||
return result
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user