1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix order of assert arguments in vm-new-script-this-context

Browse Source 
Fixes the order of assert.strictEqual arguments.

PR-URL: https://github.com/nodejs/node/pull/23558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Victor Poriazov 2018-10-12 13:55:28 -04:00 committed by Ruben Bridgewater
parent a5a1e9a2e4
commit c0014d5ff0
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/parallel/test-vm-new-script-this-context.js
View File

@ -27,7 +27,7 @@ const Script = require('vm').Script;
// Run a string // Run a string
let script = new Script('\'passed\';'); let script = new Script('\'passed\';');
const result = script.runInThisContext(script); const result = script.runInThisContext(script);
assert.strictEqual('passed', result); assert.strictEqual(result, 'passed');
// Thrown error // Thrown error
script = new Script('throw new Error(\'test\');'); script = new Script('throw new Error(\'test\');');
@ -38,7 +38,7 @@ assert.throws(() => {
global.hello = 5; global.hello = 5;
script = new Script('hello = 2'); script = new Script('hello = 2');
script.runInThisContext(script); script.runInThisContext(script);
assert.strictEqual(2, global.hello); assert.strictEqual(global.hello, 2);
// Pass values // Pass values
@ -49,15 +49,15 @@ global.foo = 2;
global.obj = { foo: 0, baz: 3 }; global.obj = { foo: 0, baz: 3 };
script = new Script(global.code); script = new Script(global.code);
script.runInThisContext(script); script.runInThisContext(script);
assert.strictEqual(0, global.obj.foo); assert.strictEqual(global.obj.foo, 0);
assert.strictEqual(2, global.bar); assert.strictEqual(global.bar, 2);
assert.strictEqual(1, global.foo); assert.strictEqual(global.foo, 1);
// Call a function // Call a function
global.f = function() { global.foo = 100; }; global.f = function() { global.foo = 100; };
script = new Script('f()'); script = new Script('f()');
script.runInThisContext(script); script.runInThisContext(script);
assert.strictEqual(100, global.foo); assert.strictEqual(global.foo, 100);
common.allowGlobals( common.allowGlobals(
global.hello, global.hello,