1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix test-net-dns-custom-lookup test assertion

Browse Source 
The assertion made an assumption that the IPv6 address would always be
`::1`. Since the address can be different on different platforms, it
has been changed to allow multiple addresses.

Fixes: https://github.com/iojs/io.js/issues/1527
PR-URL: https://github.com/iojs/io.js/pull/1531
Reviewed-By: Rod Vagg <rod@vagg.org>
This commit is contained in:
Evan Lucas 2015-04-26 08:52:10 -05:00
parent 547213913b
commit bfae8236b1
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test/parallel/test-net-dns-custom-lookup.js
View File

@ -11,15 +11,16 @@ function check(addressType, cb) {
cb && cb(); cb && cb();
}); });
var address = addressType === 4 ? '127.0.0.1' : '::1'; var address = addressType === 4 ? common.localhostIPv4 : '::1';
server.listen(common.PORT, address, function() { server.listen(common.PORT, address, function() {
net.connect({ net.connect({
port: common.PORT, port: common.PORT,
host: 'localhost', host: 'localhost',
family: addressType,
lookup: lookup lookup: lookup
}).on('lookup', function(err, ip, type) { }).on('lookup', function(err, ip, type) {
assert.equal(err, null); assert.equal(err, null);
assert.equal(ip, address); assert.equal(address, ip);
assert.equal(type, addressType); assert.equal(type, addressType);
ok = true; ok = true;
}); });
@ -27,7 +28,15 @@ function check(addressType, cb) {
function lookup(host, dnsopts, cb) { function lookup(host, dnsopts, cb) {
dnsopts.family = addressType; dnsopts.family = addressType;
dns.lookup(host, dnsopts, cb); if (addressType === 4) {
process.nextTick(function() {
cb(null, common.localhostIPv4, 4);
});
} else {
process.nextTick(function() {
cb(null, '::1', 6);
});
}
} }
} }