1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: do not use fixed port in async-hooks/test-httparser-reuse

Browse Source 
Otherwise this was failing on machines which already had a service
running on port 3000.

PR-URL: https://github.com/nodejs/node/pull/28312
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Anna Henningsen 2019-06-19 19:30:30 -07:00 committed by Rich Trott
parent d9da0a9912
commit bf7edaa3c9
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/async-hooks/test-httparser-reuse.js
View File

@ -47,10 +47,9 @@ const server = http.createServer((req, res) => {
res.end();
});
const PORT = 3000;
const url = `http://127.0.0.1:${PORT}`;
server.listen(PORT, common.mustCall(() => {
server.listen(0, common.mustCall(() => {
const PORT = server.address().port;
const url = `http://127.0.0.1:${PORT}`;
http.get(url, common.mustCall(() => {
server.close(common.mustCall(() => {
server.listen(PORT, common.mustCall(() => {