1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-init.js

Browse Source 
1. Lot of repeating code has been refactored to a function
2. Errors in async calls are properly asserted
3. Fail the test if the callbacks are not fired

PR-URL: https://github.com/nodejs/node/pull/10384
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
This commit is contained in:
Sakthipriyan Vairamani (thefourtheye) 2016-12-21 15:58:00 +05:30 committed by Julian Duque
parent 5b82800241
commit bf2c49cf71
No known key found for this signature in database
GPG Key ID: D2F1394777BDB2E2
1 changed files with 26 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
test/sequential/test-init.js
View File

@ -2,46 +2,40 @@
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const child = require('child_process'); const child = require('child_process');
const util = require('util'); const path = require('path');
if (process.env['TEST_INIT']) { if (process.env['TEST_INIT']) {
util.print('Loaded successfully!'); return process.stdout.write('Loaded successfully!');
} else { }
// change CWD as we do this test so its not dependant on current CWD
process.env.TEST_INIT = 1;
function test(file, expected) {
const path = `"${process.execPath}" ${file}`;
child.exec(path, {env: process.env}, common.mustCall((err, out) => {
assert.ifError(err);
assert.strictEqual(out, expected, `'node ${file}' failed!`);
}));
}
{
// change CWD as we do this test so it's not dependent on current CWD
// being in the test folder // being in the test folder
process.chdir(__dirname); process.chdir(__dirname);
test('test-init', 'Loaded successfully!');
test('test-init.js', 'Loaded successfully!');
}
// slow but simple {
var envCopy = JSON.parse(JSON.stringify(process.env));
envCopy.TEST_INIT = 1;
child.exec('"' + process.execPath + '" test-init', {env: envCopy},
function(err, stdout, stderr) {
assert.equal(stdout, 'Loaded successfully!',
'`node test-init` failed!');
});
child.exec('"' + process.execPath + '" test-init.js', {env: envCopy},
function(err, stdout, stderr) {
assert.equal(stdout, 'Loaded successfully!',
'`node test-init.js` failed!');
});
// test-init-index is in fixtures dir as requested by ry, so go there // test-init-index is in fixtures dir as requested by ry, so go there
process.chdir(common.fixturesDir); process.chdir(common.fixturesDir);
test('test-init-index', 'Loaded successfully!');
}
child.exec('"' + process.execPath + '" test-init-index', {env: envCopy}, {
function(err, stdout, stderr) {
assert.equal(stdout, 'Loaded successfully!',
'`node test-init-index failed!');
});
// ensures that `node fs` does not mistakenly load the native 'fs' module // ensures that `node fs` does not mistakenly load the native 'fs' module
// instead of the desired file and that the fs module loads as // instead of the desired file and that the fs module loads as
// expected in node // expected in node
process.chdir(common.fixturesDir + '/test-init-native/'); process.chdir(path.join(common.fixturesDir, 'test-init-native'));
test('fs', 'fs loaded successfully');
child.exec('"' + process.execPath + '" fs', {env: envCopy},
function(err, stdout, stderr) {
assert.equal(stdout, 'fs loaded successfully',
'`node fs` failed!');
});
} }