1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: handling failure cases properly

Browse Source 
Refer: https://github.com/nodejs/io.js/issues/1543

When this test fails, it leaves dead processes in the system. This
patch makes sure that the child processes exit first, in case of
errors.

PR-URL: https://github.com/nodejs/node/pull/2206
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
Sakthipriyan Vairamani 2015-07-19 19:20:21 +00:00
parent 34e25b2313
commit bdef668881
1 changed files with 32 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
test/parallel/test-cluster-eaccess.js
View File

@ -1,41 +1,51 @@
'use strict'; 'use strict';
// test that errors propagated from cluster children are properly // Test that errors propagated from cluster workers are properly
// received in their master creates an EADDRINUSE condition by also // received in their master. Creates an EADDRINUSE condition by forking
// forking a child process to listen on a socket // a process in child cluster and propagates the error to the master.
var common = require('../common');
var assert = require('assert');
var cluster = require('cluster');
var fork = require('child_process').fork;
var fs = require('fs');
var net = require('net');
const common = require('../common');
const assert = require('assert');
const cluster = require('cluster');
const fork = require('child_process').fork;
const fs = require('fs');
const net = require('net');
if (cluster.isMaster) { if (cluster.isMaster) {
var worker = cluster.fork(); const worker = cluster.fork();
var gotError = 0;
worker.on('message', function(err) { // makes sure master is able to fork the worker
gotError++; cluster.on('fork', common.mustCall(function() {}));
// makes sure the worker is ready
worker.on('online', common.mustCall(function() {}));
worker.on('message', common.mustCall(function(err) {
// disconnect first, so that we will not leave zombies
worker.disconnect();
console.log(err); console.log(err);
assert.strictEqual('EADDRINUSE', err.code); assert.strictEqual('EADDRINUSE', err.code);
worker.disconnect(); }));
});
process.on('exit', function() { process.on('exit', function() {
console.log('master exited'); console.log('master exited');
try { try {
fs.unlinkSync(common.PIPE); fs.unlinkSync(common.PIPE);
} catch (e) { } catch (e) {
} }
assert.equal(gotError, 1);
}); });
} else { } else {
var cp = fork(common.fixturesDir + '/listen-on-socket-and-exit.js', var cp = fork(common.fixturesDir + '/listen-on-socket-and-exit.js',
{ stdio: 'inherit' }); { stdio: 'inherit' });
// message from the child indicates it's ready and listening // message from the child indicates it's ready and listening
cp.on('message', function() { cp.on('message', common.mustCall(function() {
var server = net.createServer().listen(common.PIPE, function() { const server = net.createServer().listen(common.PIPE, function() {
console.log('parent listening, should not be!'); // message child process so that it can exit
cp.send('end');
// inform master about the unexpected situation
process.send('PIPE should have been in use.');
}); });
server.on('error', function(err) { server.on('error', function(err) {
@ -45,5 +55,6 @@ if (cluster.isMaster) {
// propagate error to parent // propagate error to parent
process.send(err); process.send(err);
}); });
});
}));
} }