1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: fix undefined timeout regression

Browse Source 
63644dd1cd6e introduced a regression caused by everyone's favourite
JavaScript feature: undefined < 0 === undefined >= 0.

Add a case to the existing tests to cover this scenario and then add
the check for undefined that makes the test pass.

PR-URL: https://github.com/nodejs/node/pull/3331
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed By: Evan Lucas <evanlucas@me.com>
This commit is contained in:
Ryan Graham 2015-10-12 16:03:59 -07:00 committed by Fedor Indutny
parent 47db2472e5
commit bde32f8a4d
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/timers.js
View File

@ -30,7 +30,7 @@ var lists = {};
// with them. // with them.
exports.active = function(item) { exports.active = function(item) {
const msecs = item._idleTimeout; const msecs = item._idleTimeout;
if (msecs < 0) return; if (msecs < 0 || msecs === undefined) return;
item._idleStart = Timer.now(); item._idleStart = Timer.now();

3
test/parallel/test-timers-active.js
View File

@ -22,7 +22,8 @@ legitTimers.forEach(function(legit) {
// active() should not create a timer for these // active() should not create a timer for these
var bogusTimers = [ var bogusTimers = [
{ _idleTimeout: -1 } { _idleTimeout: -1 },
{ _idleTimeout: undefined },
]; ];
bogusTimers.forEach(function(bogus) { bogusTimers.forEach(function(bogus) {