1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix test-child-process-stdout-flush-exit

Browse Source 
Make sure all the stdout data is available before
performing the assertions.

Fixes: https://github.com/nodejs/io.js/issues/944
PR-URL: https://github.com/nodejs/io.js/pull/1868
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This commit is contained in:
Santiago Gimeno 2015-06-02 10:39:55 +02:00 committed by Ben Noordhuis
parent d20f018dcf
commit b9267189a5
1 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/parallel/test-child-process-stdout-flush-exit.js
View File

@ -18,8 +18,7 @@ if (process.argv[2] === 'child') {
// spawn self as child // spawn self as child
var child = spawn(process.argv[0], [process.argv[1], 'child']); var child = spawn(process.argv[0], [process.argv[1], 'child']);
var gotHello = false; var stdout = '';
var gotBye = false;
child.stderr.setEncoding('utf8'); child.stderr.setEncoding('utf8');
child.stderr.on('data', function(data) { child.stderr.on('data', function(data) {
@ -30,17 +29,11 @@ if (process.argv[2] === 'child') {
// check if we receive both 'hello' at start and 'goodbye' at end // check if we receive both 'hello' at start and 'goodbye' at end
child.stdout.setEncoding('utf8'); child.stdout.setEncoding('utf8');
child.stdout.on('data', function(data) { child.stdout.on('data', function(data) {
if (data.slice(0, 6) == 'hello\n') { stdout += data;
gotHello = true;
} else if (data.slice(data.length - 8) == 'goodbye\n') {
gotBye = true;
} else {
gotBye = false;
}
}); });
child.on('close', function(data) { child.on('close', common.mustCall(function() {
assert(gotHello); assert.equal(stdout.slice(0, 6), 'hello\n');
assert(gotBye); assert.equal(stdout.slice(stdout.length - 8), 'goodbye\n');
}); }));
} }