From b8a98a807f32bf7c1a99e9a8c3f644c85b977523 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Tue, 25 Sep 2018 08:43:10 +0200 Subject: [PATCH] tools: fix cpplint --quiet option Currently, the --quiet option for cpplint will generate the following error: $ tools/cpplint.py --quiet src/node.cc Traceback (most recent call last): File "tools/cpplint.py", line 6529, in main() File "tools/cpplint.py", line 6497, in main filenames = ParseArguments(sys.argv[1:]) File "tools/cpplint.py", line 6437, in ParseArguments logger.addHandler(logging.FileHandler(val, mode='wb')) File "/python2.7/logging/__init__.py", line 911, in __init__ StreamHandler.__init__(self, self._open()) File "/python2.7/logging/__init__.py", line 941, in _open stream = open(self.baseFilename, self.mode) IOError: [Errno 21] Is a directory: '/Users/danielbevenius/work/nodejs/node This commit moves the FileHandler that currently exists in the quiet option to the logfile clause. It looks like this issue came about when merging in commit fee4d3ab90365aaff0d3469076c7ef8a3a91bc79 ("tools: merge custom cpplint with cpplint v1.3.0"). PR-URL: https://github.com/nodejs/node/pull/23075 Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Joyee Cheung --- tools/cpplint.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/cpplint.py b/tools/cpplint.py index 8afcae72a3d..f31ce284b52 100755 --- a/tools/cpplint.py +++ b/tools/cpplint.py @@ -6429,11 +6429,10 @@ def ParseArguments(args): except ValueError: PrintUsage('Extensions must be comma seperated list.') elif opt == '--recursive': - PrintUsage('Extensions must be comma separated list.') - elif opt == '--logfile': recursive = True - elif opt == '--quiet': + elif opt == '--logfile': logger.addHandler(logging.FileHandler(val, mode='wb')) + elif opt == '--quiet': global _quiet _quiet = True