1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

process_wrap: omit superfluous Number creation

Browse Source 
Don't create a superfluous Number object, just use the version of
v8::Object::Get() that takes an unsigned int. Convert the index to
unsigned int while we're here.
This commit is contained in:
Ben Noordhuis 2013-08-06 17:42:28 +02:00
parent 45d056ee69
commit b8a7eedea3
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/process_wrap.cc
View File

@ -86,13 +86,12 @@ class ProcessWrap : public HandleWrap {
uv_process_options_t* options) {
Local<Array> stdios = js_options
->Get(String::NewSymbol("stdio")).As<Array>();
int len = stdios->Length();
uint32_t len = stdios->Length();
options->stdio = new uv_stdio_container_t[len];
options->stdio_count = len;
for (int i = 0; i < len; i++) {
Local<Object> stdio = stdios
->Get(Number::New(static_cast<double>(i))).As<Object>();
for (uint32_t i = 0; i < len; i++) {
Local<Object> stdio = stdios->Get(i).As<Object>();
Local<Value> type = stdio->Get(String::NewSymbol("type"));
if (type->Equals(String::NewSymbol("ignore"))) {