1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

url: Add support for RFC 3490 separators

Browse Source 
There is no need to split the host by hand in `url.js` – Punycode.js
takes care of it anyway. This not only simplifies the code, but also
adds support for RFC 3490 separators (i.e. not just U+002E, but U+3002,
U+FF0E, and U+FF61 as well).

Closes #6055.

Reviewed-By: Fedor Indutny <fedor@indutny.com>
This commit is contained in:
Mathias Bynens 2014-08-04 12:44:06 +02:00 committed by Fedor Indutny
parent 0f2956192c
commit b869797a2d
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/url.js
View File

@ -256,18 +256,11 @@ Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost) {
} }
if (!ipv6Hostname) { if (!ipv6Hostname) {
// IDNA Support: Returns a puny coded representation of "domain". // IDNA Support: Returns a punycoded representation of "domain".
// It only converts the part of the domain name that // It only converts parts of the domain name that
// has non ASCII characters. I.e. it dosent matter if // have non-ASCII characters, i.e. it doesn't matter if
// you call it with a domain that already is in ASCII. // you call it with a domain that already is ASCII-only.
var domainArray = this.hostname.split('.'); this.hostname = punycode.toASCII(this.hostname);
var newOut = [];
for (var i = 0; i < domainArray.length; ++i) {
var s = domainArray[i];
newOut.push(s.match(/[^A-Za-z0-9_-]/) ?
'xn--' + punycode.encode(s) : s);
}
this.hostname = newOut.join('.');
} }
var p = this.port ? ':' + this.port : ''; var p = this.port ? ':' + this.port : '';