1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

crypto: move DEP0113 to End-of-Life

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/26249
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Tobias Nießen 2019-02-21 20:52:45 +01:00
parent f11e8b959d
commit b8018f407b
No known key found for this signature in database
GPG Key ID: 718207F8FD156B70
2 changed files with 7 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
doc/api/deprecations.md
View File

@ -2162,17 +2162,18 @@ accessed outside of Node.js core: `Socket.prototype._handle`,
### DEP0113: Cipher.setAuthTag(), Decipher.getAuthTag() ### DEP0113: Cipher.setAuthTag(), Decipher.getAuthTag()
<!-- YAML <!-- YAML
changes: changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/26249
description: End-of-Life.
- version: v11.0.0 - version: v11.0.0
pr-url: https://github.com/nodejs/node/pull/22126 pr-url: https://github.com/nodejs/node/pull/22126
description: Runtime deprecation. description: Runtime deprecation.
--> -->
Type: Runtime Type: End-of-Life
With the current crypto API, having `Cipher.setAuthTag()` and `Cipher.setAuthTag()` and `Decipher.getAuthTag()` are no longer available. They
`Decipher.getAuthTag()` is not helpful and both functions will throw an error were never documented and would throw when called.
when called. They have never been documented and will be removed in a future
release.
<a id="DEP0114"></a> <a id="DEP0114"></a>
### DEP0114: crypto._toBuf() ### DEP0114: crypto._toBuf()

21
lib/internal/crypto/cipher.js
View File

@ -37,7 +37,7 @@ const {
const assert = require('internal/assert'); const assert = require('internal/assert');
const LazyTransform = require('internal/streams/lazy_transform'); const LazyTransform = require('internal/streams/lazy_transform');
const { deprecate, normalizeEncoding } = require('internal/util'); const { normalizeEncoding } = require('internal/util');
// Lazy loaded for startup performance. // Lazy loaded for startup performance.
let StringDecoder; let StringDecoder;
@ -206,13 +206,6 @@ function setAuthTag(tagbuf) {
return this; return this;
} }
Object.defineProperty(Cipher.prototype, 'setAuthTag', {
get: deprecate(() => setAuthTag,
'Cipher.setAuthTag is deprecated and will be removed in a ' +
'future version of Node.js.',
'DEP0113')
});
Cipher.prototype.setAAD = function setAAD(aadbuf, options) { Cipher.prototype.setAAD = function setAAD(aadbuf, options) {
if (!isArrayBufferView(aadbuf)) { if (!isArrayBufferView(aadbuf)) {
throw new ERR_INVALID_ARG_TYPE('buffer', throw new ERR_INVALID_ARG_TYPE('buffer',
@ -243,20 +236,8 @@ function addCipherPrototypeFunctions(constructor) {
constructor.prototype.setAutoPadding = Cipher.prototype.setAutoPadding; constructor.prototype.setAutoPadding = Cipher.prototype.setAutoPadding;
if (constructor === Cipheriv) { if (constructor === Cipheriv) {
constructor.prototype.getAuthTag = Cipher.prototype.getAuthTag; constructor.prototype.getAuthTag = Cipher.prototype.getAuthTag;
Object.defineProperty(constructor.prototype, 'setAuthTag', {
get: deprecate(() => setAuthTag,
'Cipher.setAuthTag is deprecated and will be removed in ' +
'a future version of Node.js.',
'DEP0113')
});
} else { } else {
constructor.prototype.setAuthTag = setAuthTag; constructor.prototype.setAuthTag = setAuthTag;
Object.defineProperty(constructor.prototype, 'getAuthTag', {
get: deprecate(() => constructor.prototype.getAuthTag,
'Decipher.getAuthTag is deprecated and will be removed ' +
'in a future version of Node.js.',
'DEP0113')
});
} }
constructor.prototype.setAAD = Cipher.prototype.setAAD; constructor.prototype.setAAD = Cipher.prototype.setAAD;
} }