1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

events: speed up newListener/removeListener events

Browse Source
This commit is contained in:
Ben Noordhuis 2012-08-01 01:21:46 +02:00
parent 84221fd1d6
commit b7fd55e9a0
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/events.js
View File

@ -133,8 +133,10 @@ EventEmitter.prototype.addListener = function(type, listener) {
// To avoid recursion in the case that type == "newListeners"! Before // To avoid recursion in the case that type == "newListeners"! Before
// adding it to the listeners, first emit "newListeners". // adding it to the listeners, first emit "newListeners".
if (this._events.newListener) {
this.emit('newListener', type, typeof listener.listener === 'function' ? this.emit('newListener', type, typeof listener.listener === 'function' ?
listener.listener : listener); listener.listener : listener);
}
if (!this._events[type]) { if (!this._events[type]) {
// Optimize the case of one listener. Don't need the extra array object. // Optimize the case of one listener. Don't need the extra array object.
@ -217,13 +219,19 @@ EventEmitter.prototype.removeListener = function(type, listener) {
list.splice(position, 1); list.splice(position, 1);
if (list.length == 0) if (list.length == 0)
delete this._events[type]; delete this._events[type];
if (this._events.removeListener) {
this.emit('removeListener', type, listener); this.emit('removeListener', type, listener);
}
} else if (list === listener || } else if (list === listener ||
(list.listener && list.listener === listener)) (list.listener && list.listener === listener))
{ {
delete this._events[type]; delete this._events[type];
if (this._events.removeListener) {
this.emit('removeListener', type, listener); this.emit('removeListener', type, listener);
} }
}
return this; return this;
}; };