1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: swap arguments in strictEqual()

Browse Source 
This commit also comments the third argument

PR-URL: https://github.com/nodejs/node/pull/21660
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Sohail Rajdev 2018-07-04 23:10:03 +05:30 committed by Trivikram Kamat
parent e56fec0722
commit b70db33670
1 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
test/pummel/test-timers.js
View File

@ -31,7 +31,7 @@ let interval_count = 0;
clearTimeout(null); clearTimeout(null);
clearInterval(null); clearInterval(null);
assert.strictEqual(true, setTimeout instanceof Function); assert.strictEqual(setTimeout instanceof Function, true);
const starttime = new Date(); const starttime = new Date();
setTimeout(common.mustCall(function() { setTimeout(common.mustCall(function() {
const endtime = new Date(); const endtime = new Date();
@ -40,7 +40,7 @@ setTimeout(common.mustCall(function() {
assert.ok(diff > 0); assert.ok(diff > 0);
console.error(`diff: ${diff}`); console.error(`diff: ${diff}`);
assert.strictEqual(true, 1000 - WINDOW < diff && diff < 1000 + WINDOW); assert.strictEqual(1000 - WINDOW < diff && diff < 1000 + WINDOW, true);
}), 1000); }), 1000);
// this timer shouldn't execute // this timer shouldn't execute
@ -57,9 +57,9 @@ setInterval(function() {
const t = interval_count * 1000; const t = interval_count * 1000;
assert.strictEqual(true, t - WINDOW < diff && diff < t + WINDOW); assert.strictEqual(t - WINDOW < diff && diff < t + WINDOW, true);
assert.strictEqual(true, interval_count <= 3); assert.strictEqual(interval_count <= 3, true);
if (interval_count === 3) if (interval_count === 3)
clearInterval(this); clearInterval(this);
}, 1000); }, 1000);
@ -67,13 +67,13 @@ setInterval(function() {
// Single param: // Single param:
setTimeout(function(param) { setTimeout(function(param) {
assert.strictEqual('test param', param); assert.strictEqual(param, 'test param');
}, 1000, 'test param'); }, 1000, 'test param');
let interval_count2 = 0; let interval_count2 = 0;
setInterval(function(param) { setInterval(function(param) {
++interval_count2; ++interval_count2;
assert.strictEqual('test param', param); assert.strictEqual(param, 'test param');
if (interval_count2 === 3) if (interval_count2 === 3)
clearInterval(this); clearInterval(this);
@ -82,15 +82,15 @@ setInterval(function(param) {
// Multiple param // Multiple param
setTimeout(function(param1, param2) { setTimeout(function(param1, param2) {
assert.strictEqual('param1', param1); assert.strictEqual(param1, 'param1');
assert.strictEqual('param2', param2); assert.strictEqual(param2, 'param2');
}, 1000, 'param1', 'param2'); }, 1000, 'param1', 'param2');
let interval_count3 = 0; let interval_count3 = 0;
setInterval(function(param1, param2) { setInterval(function(param1, param2) {
++interval_count3; ++interval_count3;
assert.strictEqual('param1', param1); assert.strictEqual(param1, 'param1');
assert.strictEqual('param2', param2); assert.strictEqual(param2, 'param2');
if (interval_count3 === 3) if (interval_count3 === 3)
clearInterval(this); clearInterval(this);
@ -120,8 +120,9 @@ clearTimeout(y);
process.on('exit', function() { process.on('exit', function() {
assert.strictEqual(3, interval_count); assert.strictEqual(interval_count, 3);
assert.strictEqual(11, count4); assert.strictEqual(count4, 11);
assert.strictEqual(0, expectedTimeouts,
'clearTimeout cleared too many timeouts'); // Check that the correct number of timers ran.
assert.strictEqual(expectedTimeouts, 0);
}); });