1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: check number of message events

Browse Source 
When a no-op message event handler is used in a test, make it clear what
is expected by using `common.mustCall()` and `common.mustNotCall()`.

PR-URL: https://github.com/nodejs/node/pull/13125
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Rich Trott 2017-05-19 22:14:21 -07:00 committed by Anna Henningsen
parent 47919b3b6f
commit b5b6f5d6a9
No known key found for this signature in database
GPG Key ID: D8B9F5AEAE84E4CF
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-child-process-fork-ref2.js
View File

@ -29,7 +29,7 @@ if (process.argv[2] === 'child') {
setTimeout(function() {
console.log('child -> will this keep it alive?');
process.on('message', common.noop);
process.on('message', common.mustNotCall());
}, 400);
} else {

2
test/sequential/test-child-process-pass-fd.js
View File

@ -45,7 +45,7 @@ if (process.argv[2] !== 'child') {
// the only thing keeping this worker alive will be IPC. This is important,
// because it means a worker with no parent will have no referenced handles,
// thus no work to do, and will exit immediately, preventing process leaks.
process.on('message', common.noop);
process.on('message', common.mustCall());
const server = net.createServer((c) => {
process.once('message', function(msg) {